[coreboot] [PATCH] Add .text into romstage sections.

Stefan Reinauer stefan.reinauer at coreboot.org
Thu Feb 24 02:45:22 CET 2011


* Bao, Zheng <Zheng.Bao at amd.com> [110223 03:31]:
> The ldscript_fallback_cbfs.lb is only for the romstage. It does
> nothing to change the building of ramstage. And it doesn't have area
> like .data, which can be read and wrote.
> 
> From the attached build output, we can see that only crt0.romstage.o
> changes .rodata to rom.data, changes .text to .rom.text.  Other
> romstage files like console.romstage.o only have .text., without
> .rom.text, .rom.data, or .data.
 
I believe this is an odd survivor from romcc-only times. Is there a
reason on non-romcc builds to move any code into .rom.* sections at all?

If not, we should remove that behavior completely and just have it
include .text and .rodata in the ld script. (which should be called
romstage.ld and not ldscript_fallback_cbfs.lb)

> From the 2 romstage.map(s), we can see where the _erom should be.
> 
> Compared to the patch to ldscript_fallback_cbfs.lb, we can also change
> other romstage's .text to .rom.text. But I don't think it is worth to
> do such a complicated job.
> 
> Zheng

Stefan




More information about the coreboot mailing list