[coreboot] [PATCH] disabling microcode update
ward at gnu.org
Thu Feb 24 22:12:59 CET 2011
On Wed, Feb 23, 2011 at 02:51:46PM +0100, Xavi Drudis Ferran wrote:
> If you mean visible in the source code:
> Option A:
> the patch I sent changes only one .c file and one Kconfig file. The function update_microcode()
> would still exist and it would do the update or do nothing depending on CONFIG_UPDATE_CPU_MICROCODE.
> No other files would need touching.
> This is what my software engineer intuition recommends, centralise changes in one place, change
> the behaviour of a procedure depending on configuration options, don't change every single place
> that procedure is called.
> But people have considered this to be too little visible, or too little invasive for its heretic nature,
> or I don't quite understand what, and they've asked
> Option B:
> change src/cpu/amd/model_10xxx/Makefile.inc
> so that update_microcode.c does not get compiled in. when CONFIG_UPDATE_CPU_MICROCODE is false
> since in that case the function update_microcode(...) would be undefined, we would have to also
> change all files with a call to it, by placing an #if around the call. Those files are
> (and by */* I mean all or some of the fam 10 boards, not all boards).
This is the option that Stepan and Peter prefer, so this seems like the best
way forward? I'd test and ack this patch.
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator
More information about the coreboot