[coreboot] [PATCH] outb(* 0x80) to post_code()

[Alex G.]

Signed-off-by Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
On 02/26/2011 02:58 AM, Stefan Reinauer wrote:
>>> Can we put this in one file together with
[...]
>>>   src/include/cpu/x86/post_code.h
>>
>> No. This would ruin the behavior of post_code() in console.c, which also
>> outputs to console if the option is selected.
> 
> Why? Just add #ifdef ASSEMBLY around it. Then it won't be visible in
> console.c (or console.h for that matter)
>
Aaah. The obscure quirks. done.


>> On 02/25/2011 11:59 PM, Stefan Reinauer wrote:
>>>
>>> refactored... should we move the delay function to a common place?
>>>
>> I can move it. Just which file ? Also, wouldn't this make a single patch
>> too hard to swallow?
> 
> Yes. I think you should remove all changes to smbus* files from your
> patch and then we can look at the issue separately.
> 
Been there. Done that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: post_codes.patch
Type: text/x-patch
Size: 43820 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110226/f0866010/attachment.patch>