[coreboot] [PATCH] disabling microcode update

[xdrudis]

On Sat, Feb 26, 2011 at 07:17:46PM +0100, Peter Stuge wrote:
> xdrudis wrote:
> > > HT Frequencies are multiples of 200MHz AFAIK, so there are no
> > > 300MHz and 500MHz.
> ..
> > Oh! You may well be right. All others are multiples of 200 MHz .
> > 
> > Then we should maybe remove 2 #elif in the following code. But I
> > wonder whether the break in the progression of values indicates
> > that all values from there on should be changed too.
> 
> A safer change might be:
> 
> > #elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_300
> > #elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_500
> 
> #elif CONFIG_EXPERT && defined(CONFIG_LIMIT_HT_SPEED_300) && CONFIG_LIMIT_HT_SPEED_300
> #elif CONFIG_EXPERT && defined(CONFIG_LIMIT_HT_SPEED_500) && CONFIG_LIMIT_HT_SPEED_500
> 
> 
> I would ack that if it builds.
> 


I'd rather wait to see if someone who understands the code knows
whether 300 and 500 make sense (then we define them as in my patch) or
they don't (then we eliminate the #elif and maybe modify some values
around there). What you propose just defers the real
question to Kconfig. Besides, without my patch, I don't think
CONFIG_LIMIT_HT_SPEED_300 and CONFIG_LIMIT_HT_SPEED_500 are defined
anyware, so you're solution is equivalent to eliminaing the #elif.