[coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

Stefan Reinauer stepan at coreboot.org
Sun Jan 16 23:20:50 CET 2011


* Kevin O'Connor <kevin at koconnor.net> [110116 18:59]:
> The cn700.c code references mainboard_interrupt_handlers() which isn't
> defined if VGA_ROM_RUN is off.  Define a dummy implementation of that
> function for this case.
> 
> Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
Acked-by: Stefan Reinauer <stepan at coreboot.org>

And I think the extern should also be removed. It's not needed for
functions.

> ---
>  src/arch/x86/include/arch/interrupt.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/src/arch/x86/include/arch/interrupt.h b/src/arch/x86/include/arch/interrupt.h
> index 2d2330b..c3cda30 100644
> --- a/src/arch/x86/include/arch/interrupt.h
> +++ b/src/arch/x86/include/arch/interrupt.h
> @@ -22,4 +22,8 @@
>  #include "registers.h"
>  
>  /* setup interrupt handlers for mainboard */
> +#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
>  extern void mainboard_interrupt_handlers(int intXX, void *intXX_func);
> +#else
> +static inline void mainboard_interrupt_handlers(int intXX, void *intXX_func) { }
> +#endif
> -- 
> 1.7.3.4
> 
> 
> -- 
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
> 




More information about the coreboot mailing list