[coreboot] [commit] r6418 - trunk/src/northbridge/amd/lx

Nils njacobs8 at hetnet.nl
Wed Mar 2 21:13:33 CET 2011


Hi Patrick,

>Author: oxygene
>Date: Tue Mar  1 08:30:14 2011
>New Revision: 6418
>URL: https://tracker.coreboot.org/trac/coreboot/changeset/6418
>
>Log:
>Mark non-returning function as noreturn to help some compiler versions
>
>Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
>Acked-by: Patrick Georgi <patrick.georgi at secunet.com>
>
>Modified:
>   trunk/src/northbridge/amd/lx/raminit.c
>
>Modified: trunk/src/northbridge/amd/lx/raminit.c
>==============================================================================
>--- trunk/src/northbridge/amd/lx/raminit.c      Tue Mar  1 08:26:00 2011        
>(r6417)
>+++ trunk/src/northbridge/amd/lx/raminit.c      Tue Mar  1 08:30:14 2011        
>(r6418)
>@@ -32,7 +32,7 @@
>        printk(BIOS_DEBUG, " * %s\n", s);
> }
> 
>-static void hcf(void)
>+static void __attribute__((noreturn)) hcf(void)
> {
>        print_emerg("DIE\n");
>        /* this guarantees we flush the UART fifos (if any) and also

Should this change also be applied for the almost same function in Geode GX2?

Thanks,Nils.




More information about the coreboot mailing list