[coreboot] [PATCH 2/3] ec/acpi: make ACPI register pair configurable

Sven Schnelle svens at stackframe.org
Sat Mar 12 09:23:55 CET 2011

Stefan Reinauer <stefan.reinauer at coreboot.org> writes:

> * Sven Schnelle <svens at stackframe.org> [110312 01:18]:
>> Signed-off-by: Sven Schnelle <svens at stackframe.org>
>> ---
>>  src/ec/acpi/ec.c |   23 ++++++++++++++++-------
>>  src/ec/acpi/ec.h |    1 +
>>  2 files changed, 17 insertions(+), 7 deletions(-)
> I wonder if you want two sets of access functions, like on the Getac
> P470 instead of changing the base address on the fly.

I like the Adress configuration more. Accessing the 0x1600/0x1604
register pair works the same way as the 0x62/0x66 pair, so i dont
like to copy all the accessor function just because the base address
changed. And the performance impact of looking up the addresses instead
of having it as a literal in the outb asembler instruction is probably


More information about the coreboot mailing list