[coreboot] [PATCH] Replace the values of APIC timer init with macros

Vikram Narayanan vikram186 at gmail.com
Sat May 7 21:04:16 CEST 2011


This replaces the fixed shift values in the apic timer init with macros.

Signed-off by: Vikram Narayanan <vikram186 at gmail.com>
---
--- a/src/cpu/x86/lapic/apic_timer.c	Sun May  8 00:18:12 2011
+++ b/src/cpu/x86/lapic/apic_timer.c	Sun May  8 00:08:54 2011
@@ -36,7 +36,7 @@
 	msr_t fsb_clock_sts;
 
 	/* Set the apic timer to no interrupts and periodic mode */
-	lapic_write(LAPIC_LVTT, (1 << 17) | (1<< 16) | (0 << 12) | (0 << 0));
+	lapic_write(LAPIC_LVTT, (LAPIC_LVT_TIMER_PERIODIC | LAPIC_LVT_MASKED));
 
 	/* Set the divider to 1, no divider */
 	lapic_write(LAPIC_TDCR, LAPIC_TDR_DIV_1);

Thanks,
Vikram





More information about the coreboot mailing list