[coreboot] Kconfig vs. devicetree vs. CMOS policy for options?

Peter Stuge peter at stuge.se
Mon May 16 01:42:52 CEST 2011


Hi,

repository service wrote:
> Enable AHCI mode and hide IDE controller
..

> +++ trunk/src/southbridge/amd/cimx_wrapper/sb800/cfg.c	Sun May 15 23:38:08 2011	(r6579)
> @@ -83,7 +83,7 @@
>    	sb_config->SATAMODE.SataMode.SataController = SATA_CONTROLLER;
>  	sb_config->SATAMODE.SataMode.SataIdeCombMdPriSecOpt = 0; //0 -IDE as primary, 1 -IDE as secondary.
>  								//TODO: set to secondary not take effect.
> -	sb_config->SATAMODE.SataMode.SataIdeCombinedMode = 0; //IDE controlor exposed and combined mode enabled
> +	sb_config->SATAMODE.SataMode.SataIdeCombinedMode = 1; //IDE controllor is hidden
..

> +++ trunk/src/southbridge/amd/cimx_wrapper/sb800/cfg.h	Sun May 15 23:38:08 2011	(r6579)
> @@ -109,7 +109,7 @@
>   *   NOTE: DO NOT ALLOW SATA & IDE use same mode
>   */
>  #ifndef SATA_MODE
> -  #define SATA_MODE			NATIVE_IDE_MODE
> +  #define SATA_MODE			AHCI_MODE
>  #endif
..

> +++ trunk/src/southbridge/amd/cimx_wrapper/sb800/late.c	Sun May 15 23:38:08 2011	(r6579)
> @@ -138,10 +138,9 @@
>  static const struct pci_driver sata_driver __pci_driver = {
>  	.ops = &sata_ops,
>  	.vendor = PCI_VENDOR_ID_ATI,
> -	.device = PCI_DEVICE_ID_ATI_SB800_SATA, //SATA IDE Mode 4390
> +	.device = PCI_DEVICE_ID_ATI_SB800_SATA_AHCI,
>  };

Reading this I think that there should be a Kconfig option to choose
if the chipset should be set up as SATA IDE or AHCI.

Talking to a lot of visitors at LinuxTag it is absolutely clear that
this is an example of what should actually be an NVRAM option.

Do we have some policy for where to place an option? I don't think we
do. Do we want to create one?

The purpose is to have a perfectly streamlined user experience across
all different mainboards. Of course all boards don't support all
options, but when two different boards *do* support an option, that
option must be in the same place, working the same way.

The balance between compile time options and NVRAM options is not so
easy. :\


//Peter




More information about the coreboot mailing list