[coreboot] New patch to review for coreboot: 47c17ed Fix CMOS handling for non-USE_OPTION_TABLE configuration

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Nov 22 14:14:07 CET 2011


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/442

-gerrit

commit 47c17ed4903029017a2e2cce390e549e3dce7f19
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Tue Nov 22 10:27:24 2011 +0100

    Fix CMOS handling for non-USE_OPTION_TABLE configuration
    
    The read_option macro still emitted CMOS_VSTART_*/CMOS_VEND_* symbols,
    which fail without an option table (as no option_table.h defines them).
    
    Discard them by using a macro instead of a static inline function.
    
    Change-Id: I8d001f971681277a344b6788725746491546b607
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 src/include/pc80/mc146818rtc.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index d6dcf01..3e5a61a 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -116,8 +116,7 @@ unsigned read_option_lowlevel(unsigned start, unsigned size, unsigned def);
 static inline int set_option(const char *name __attribute__((unused)), void *val __attribute__((unused))) { return -2; };
 static inline int get_option(void *dest __attribute__((unused)),
 	const char *name __attribute__((unused))) { return -2; }
-static inline unsigned read_option_lowlevel(unsigned start, unsigned size, unsigned def)
-	{ return def; }
+#define read_option_lowlevel(start, size, def) def
 #endif
 #else
 #include <pc80/mc146818rtc_early.c>




More information about the coreboot mailing list