[coreboot] New patch to review for coreboot: 5b687b2 k8 raminit: add workaround for erratum #181 on non-fam-f

Florian Zumbiehl gerrit at coreboot.org
Tue Nov 22 21:37:07 CET 2011


Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/448

-gerrit

commit 5b687b2c7ab6c1ca9647e9e714f87a619029777f
Author: Florian Zumbiehl <florz at florz.de>
Date:   Tue Nov 22 21:32:31 2011 +0100

    k8 raminit: add workaround for erratum #181 on non-fam-f
    
    Disable DRAM controller on non-fam-f CPUs not using fam-f register layout.
    
    Change-Id: I2cc87857452555011d69bfebe9f9c4c17cef8f6c
    Signed-off-by: Florian Zumbiehl <florz at florz.de>
---
 src/cpu/amd/model_fxx/fidvid.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/src/cpu/amd/model_fxx/fidvid.c b/src/cpu/amd/model_fxx/fidvid.c
index 6395a1e..06ff636 100644
--- a/src/cpu/amd/model_fxx/fidvid.c
+++ b/src/cpu/amd/model_fxx/fidvid.c
@@ -45,10 +45,19 @@ static void enable_fid_change(void)
 		pci_write_config32(PCI_DEV(0, 0x18 + i, 3), 0xd4, dword);
 
 		/* disable the DRAM interface at first, it will be enabled
-		 * by raminit again */
+		 * by raminit again (see also erratum #181) */
+#if CONFIG_K8_REV_F_SUPPORT
 		dword = pci_read_config32(PCI_DEV(0, 0x18 + i, 2), 0x94);
 		dword |= (1 << 14);
 		pci_write_config32(PCI_DEV(0, 0x18 + i, 2), 0x94, dword);
+#else
+		dword = pci_read_config32(PCI_DEV(0, 0x18 + i, 2), 0x90);
+		dword |= (1 << 24);
+		pci_write_config32(PCI_DEV(0, 0x18 + i, 2), 0x90, dword);
+		dword = pci_read_config32(PCI_DEV(0, 0x18 + i, 2), 0x94);
+		dword |= (1 << 25);
+		pci_write_config32(PCI_DEV(0, 0x18 + i, 2), 0x94, dword);
+#endif
 
 		dword = 0x23070700;	/* enable FID/VID change */
 //              dword = 0x00070000; /* enable FID/VID change */




More information about the coreboot mailing list