[coreboot] Patch set updated for coreboot: 84aaa51 SB800: Hide unused gpp ports

Kerry Sheh (shekairui@gmail.com) gerrit at coreboot.org
Wed Oct 12 05:48:06 CEST 2011


Kerry Sheh (shekairui at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/207

-gerrit

commit 84aaa51051020920f5f42b7ea4c2410693cba36a
Author: Kerry Sheh <shekairui at gmail.com>
Date:   Wed Oct 12 12:06:23 2011 +0800

    SB800: Hide unused gpp ports
    
    Add configure option SB_GPP_UNHIDE_PORTS for mainboard
    to hide/unhide the unused sb800 gpp ports.
    Certain gpp port should be hidden, if no device was detected and
    hotplug feature is disabled for such port.
    Hidden unused ports makes lspci -vvv get more accurate information under Linux.
    Test on avalue/eax-785e mainboard.
    
    Change-Id: I1d7df0f2ab6ad69b1b99b8bf046411ae7cdb09c0
    Signed-off-by: Kerry Sheh <kerry.she at amd.com>
    Signed-off-by: Kerry Sheh <shekairui at gmail.com>
---
 src/mainboard/advansus/a785e-i/platform_cfg.h |    6 ++++++
 src/mainboard/amd/inagua/platform_cfg.h       |    6 ++++++
 src/mainboard/amd/persimmon/platform_cfg.h    |    6 ++++++
 src/mainboard/asrock/e350m1/platform_cfg.h    |    6 ++++++
 src/southbridge/amd/cimx/sb800/cfg.c          |    2 +-
 5 files changed, 25 insertions(+), 1 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/platform_cfg.h b/src/mainboard/advansus/a785e-i/platform_cfg.h
index ee68386..5fd49d6 100644
--- a/src/mainboard/advansus/a785e-i/platform_cfg.h
+++ b/src/mainboard/advansus/a785e-i/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/amd/inagua/platform_cfg.h b/src/mainboard/amd/inagua/platform_cfg.h
index 4a3f080..aa7cb5c 100644
--- a/src/mainboard/amd/inagua/platform_cfg.h
+++ b/src/mainboard/amd/inagua/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index e4fedd9..66aab8b 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h
index a0cbd11..6aa31d2 100644
--- a/src/mainboard/asrock/e350m1/platform_cfg.h
+++ b/src/mainboard/asrock/e350m1/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c
index a34dd14..2998fa2 100644
--- a/src/southbridge/amd/cimx/sb800/cfg.c
+++ b/src/southbridge/amd/cimx/sb800/cfg.c
@@ -108,7 +108,7 @@ void sb800_cimx_config(AMDSBCFG *sb_config)
 	sb_config->PORTCONFIG[1].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
 	sb_config->PORTCONFIG[2].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
 	sb_config->PORTCONFIG[3].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
-	sb_config->GppUnhidePorts = TRUE; //visable always, even port empty
+	sb_config->GppUnhidePorts = SB_GPP_UNHIDE_PORTS;
 	sb_config->NbSbGen2 = NB_SB_GEN2;
 	sb_config->GppGen2 = SB_GPP_GEN2;
 




More information about the coreboot mailing list