[coreboot] missing read resources

[Myles Watson]

On Thu, Oct 13, 2011 at 1:47 AM, Stefan Reinauer
<stefan.reinauer at coreboot.org> wrote:
> * Myles Watson <mylesgw at gmail.com> [111012 08:19]:
>> On Tue, Oct 11, 2011 at 10:13 PM, Oskar Enoksson <enok at lysator.liu.se> wrote:
>> > I get the following warnings:
>> >
>> > APIC: 00 missing read_resources
>> > APIC: 01 missing read_resources
>> > APIC: 02 missing read_resources
>> > APIC: 03 missing read_resources
>> > I2C: 01:08 missing read_resources
>> > I2C: 04:50 missing read_resources
>> > I2C: 04:51 missing read_resources
>> > I2C: 04:52 missing read_resources
>> > I2C: 04:53 missing read_resources
>> > I2C: 05:50 missing read_resources
>> > I2C: 05:51 missing read_resources
>> > I2C: 05:52 missing read_resources
>> > I2C: 05:53 missing read_resources
>> > I2C: 03:69 missing read_resources
>> >
>> > What does it mean? Should I do something about it in devicetree.cb?
>>
>> It just means that I2C and APIC devices don't have resources to read,
>> and the warning message was less annoying than implementing empty
>> functions that might get copied to a device that had resources.
>>
>> It can be safely ignored for those two classes of devices.
>
> Should it be BIOS_SPEW than instead of BIOS_ERR?

It should be for those devices, but it is an error for devices that
should have the function.  That was the reason we left it.  I think
putting in a read_no_resources() function for those devices would be
the cleanest solution.  The downside was that people implementing a
new device might put in a dummy function to silence the error and
never figure out why their device didn't work.  I don't think we can
protect against things like that, though.

Thanks,
Myles