[coreboot] New patch to review for coreboot: b11deb8 cbfstool: improve error messages
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Sat Oct 15 00:27:00 CEST 2011
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/271
-gerrit
commit b11deb89f181728f75071778f22580408e74c3fd
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Fri Oct 14 12:44:14 2011 -0700
cbfstool: improve error messages
If a file can't be added by cbfstool, print the type and name of the file
in the error message.
Change-Id: I369d6f5be09ec53ee5beea2cfea65a80407f0ba3
Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
util/cbfstool/cbfstool.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 4c28c29..f017b2e 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -81,8 +81,10 @@ static int cbfs_add(int argc, char **argv)
base = strtoul(argv[6], NULL, 0);
}
cbfsfile = create_cbfs_file(cbfsname, filedata, &filesize, type, &base);
- if (add_file_to_cbfs(cbfsfile, filesize, base))
+ if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+ printf("Adding file '%s' failed.\n", filename);
return 1;
+ }
if (writerom(romname, rom, romsize))
return 1;
return 0;
@@ -130,8 +132,10 @@ static int cbfs_add_payload(int argc, char **argv)
cbfsfile =
create_cbfs_file(cbfsname, payload, &filesize,
CBFS_COMPONENT_PAYLOAD, &base);
- if (add_file_to_cbfs(cbfsfile, filesize, base))
+ if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+ printf("Adding payload '%s' failed.\n", filename);
return 1;
+ }
if (writerom(romname, rom, romsize))
return 1;
return 0;
@@ -180,8 +184,10 @@ static int cbfs_add_stage(int argc, char **argv)
create_cbfs_file(cbfsname, stage, &filesize,
CBFS_COMPONENT_STAGE, &base);
- if (add_file_to_cbfs(cbfsfile, filesize, base))
+ if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+ printf("Adding stage '%s' failed.\n", filename);
return 1;
+ }
if (writerom(romname, rom, romsize))
return 1;
return 0;
More information about the coreboot
mailing list