[coreboot] New patch to review for coreboot: 6a22d1c w83627hf: correct typo in ASL include, correct indexed registers and remove unneccesary _PR0 defs
Christoph Grenz (christophg+cb@grenz-bonn.de)
gerrit at coreboot.org
Wed Oct 19 02:28:04 CEST 2011
Christoph Grenz (christophg+cb at grenz-bonn.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/296
-gerrit
commit 6a22d1c7e41a6ee47d32572afebc035c114390a3
Author: Christoph Grenz <christophg+cb at grenz-bonn.de>
Date: Wed Oct 19 02:24:23 2011 +0200
w83627hf: correct typo in ASL include, correct indexed registers and remove unneccesary _PR0 defs
Correct a typo in devtree.asl which causes AML processors to fail executing
the DSDT with AE_NO_MEMORY or (in case of acpiexec) Divide By Zero.
Also removes an superfluous item in the register IndexField and removes
unneccessary _PR0 definitions which could confuse AML processors.
Change-Id: I02cb9ce4e8f2101cfff8cec4abba7e070fd66364
Signed-off-by: Christoph Grenz <christophg+cb at grenz-bonn.de>
---
src/superio/winbond/w83627hf/devtree.asl | 11 ++---------
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/superio/winbond/w83627hf/devtree.asl b/src/superio/winbond/w83627hf/devtree.asl
index fa78845..cbc132d 100644
--- a/src/superio/winbond/w83627hf/devtree.asl
+++ b/src/superio/winbond/w83627hf/devtree.asl
@@ -74,7 +74,7 @@ Scope (\_SB)
ADDR, 8,
DATA, 8
}
- IndexField (CREG, DATA, ByteAcc, NoLock, Preserve)
+ IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve)
{
Offset (0x02),
RST, 1, /* Soft reset */
@@ -84,7 +84,6 @@ Scope (\_SB)
Offset (0x20),
DID, 8, /* Device ID */
DREV, 8, /* Device Revision */
- POWC, 8,
FDPW, 1, /* FDC Power Down */
, 2,
PRPW, 1, /* PRT Power Down */
@@ -258,7 +257,6 @@ Scope (\_SB)
Store (One, FDPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -470,7 +468,6 @@ Scope (\_SB)
Store (One, PRPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS) {
ENCM ()
@@ -650,7 +647,6 @@ Scope (\_SB)
Store (One, UAPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -783,7 +779,6 @@ Scope (\_SB)
Store (One, UBPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -916,7 +911,6 @@ Scope (\_SB)
Store (One, UBPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_DIS)
{
@@ -1479,7 +1473,6 @@ Scope (\_SB)
Store (One, HWPW)
EXCM ()
}
- Name (_PR0, Package () { ^^ })
Method (_CRS)
{
@@ -1511,4 +1504,4 @@ Scope (\_SB)
}
#endif
}
-}
\ No newline at end of file
+}
More information about the coreboot
mailing list