[coreboot] New patch to review for coreboot: 6a22d1c w83627hf: correct typo in ASL include, correct indexed registers and remove unneccesary _PR0 defs

[Christoph Grenz]

Am Mittwoch, 19. Oktober 2011, um 22:52:16 schrieb Oskar Enoksson:
> Your recent changes make the error messages go away.
> 
> However, I noticed another error message about PS2 controller:
> 
> [    1.543494] i8042 kbd 00:02: unable to assign resources
> [    1.584667] i8042 kbd: probe of 00:02 failed with error -16
> [    1.625694] i8042 aux 00:03: [irq 12]
> [    1.626460] i8042 aux 00:03: activated
> [    1.666536] PNP: PS/2 Controller [PNP0f13:PS2M] at 0x0,0x0 irq 12
> [    1.706908] PNP: PS/2 controller has invalid data port 0x0; using
> default 0x60
> [    1.747678] PNP: PS/2 controller has invalid command port 0x0; using
> default 0x64
> [    1.788888] PNP: PS/2 controller doesn't have KBD irq; using default 1
> [    2.081400] serio: i8042 KBD port at 0x60,0x64 irq 1
> [    2.122528] mice: PS/2 mouse device common for all mice

Do you have a PS/2 keyboard and/or mouse attached to your computer?

I reproduced similar output on my board with no PS/2 device attached. (I don't 
own any PS/2 keyboard/mouse so I can't test the other cases)
It seems that the PS/2 controller is disabled on startup.
When the i8042 kbd driver probes the KBD0 device _STA reports that the device 
isn't enabled. It then seems to read the I/O ports (which are uninitialized, 
so 0x00, 0x00) so it tries to enable it and either it fails or really enables 
it and reports a failure (I'm not yet sure about the reason, I couldn't find 
much info about error -16 yet). Anyway later when the aux driver probes PS2M 
it is enabled, so this one doesn't fail.

Can you send the output from superiotool -d? I would like to see if there are 
really only zeroes in the keyboard controller IO port registers.

> I also saw something that looks like bug in your code (my proposed
> changes below). However, it doesn't cure the above error messages, so I
> may be wrong ...
> 
> @@ -1148,7 +1142,7 @@ Scope (\_SB)
>                                  Or (Local1, Local0, Local0)
> 
>                                  ShiftLeft(Local2, 8, Local2)
> -                               Or (Local1, Local0, Local0)
> +                               Or (Local3, Local2, Local2)
> 
>                                  CreateWordField (CRS, IO0._MIN, IMIN)
>                                  Store (Local0, IMIN)
> [...]

Oops, yes these are copy-paste errors. I'll correct them.

BTW, thanks for testing the code