[coreboot] Patch merged into coreboot/master: 0e277fb Add acpi_get_sleep_type() to i82371eb and P2B _PTS/_WAK methods

gerrit at coreboot.org gerrit at coreboot.org
Mon Sep 12 15:56:13 CEST 2011

the following patch was just integrated into master:
commit 0e277fb131ed9eee75c1b1c6641b2ac7c2635165
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Mon Dec 13 22:39:46 2010 +0100

    Add acpi_get_sleep_type() to i82371eb and P2B _PTS/_WAK methods
    Build fix for src/arch/i386/boot/acpi.c if !CONFIG_SMP
    Also check for acpi_slp_type 2 in acpi_is_wakeup, since S2
    uses the same acpi wakeup vector as S3.
    Add _PTS/_WAK methods to turn off/on the CPU/case fans and blink
    the power LED while sleeping.
    acpi_get_sleep_type() is in a seperate file i82371eb_wakeup.c because
    it is used in both romstage and ramstage after patch 3/3, whereas
    i82371eb_early_pm.c is used only in romstage.
    I used the name acpi_get_sleep_type instead of  acpi_is_wakeup_early
    because I think acpi_is_wakeup_early is a bit misleading as a name since it
    doesn't return a boolean value.
    Other chipsets so far only ever set acpi_slp_type to 0 and 3, so the
    added check for acpi_slp_type == 2 (resume from S2) should not
    change behaviour of other boards:
    northbridge/intel/i945/northbridge.c:256:extern u8 acpi_slp_type;
    northbridge/intel/i945/northbridge.c:263: acpi_slp_type=0;
    northbridge/intel/i945/northbridge.c:267: acpi_slp_type=3;
    northbridge/intel/i945/northbridge.c:271: acpi_slp_type=0;
    southbridge/intel/i82801gx/i82801gx_lpc.c:171:extern u8 acpi_slp_type;
    southbridge/via/vt8237r/vt8237r_lpc.c:149:extern u8 acpi_slp_type;
    southbridge/via/vt8237r/vt8237r_lpc.c:238:  acpi_slp_type = ((tmp & (7 << 10)) >> 10) == 1 ? 3 : 0 ;
    southbridge/via/vt8237r/vt8237r_lpc.c:239:  printk(BIOS_DEBUG, "SLP_TYP type was %x %x\n", tmp, acpi_slp_type);
    Change-Id: I13feff0b8f49aa988e5467cdbef02981f0a6be8a
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>

See http://review.coreboot.org/188 for details.


More information about the coreboot mailing list