[coreboot] New patch to review for coreboot: c1c064a inteltool: Fixed building of position independent executables

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Sep 13 10:50:47 CEST 2011

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/209


commit c1c064a15d20f3591784ab91d80f8d7789cb3096
Author: Mathias Krause <mathias.krause at secunet.com>
Date:   Wed Mar 9 11:30:55 2011 +0100

    inteltool: Fixed building of position independent executables
    When building a position independent executable (PIE) EBX is used
    internally by the compiler to generate position independent address
    references so it cannot be used in the clobber list. Use the already
    existing code for the Darwin plattform for that case, too -- it'll
    preserve the EBX value.
    Change-Id: Ief6d4872b8cd990856a0e8227a88bb228782aced
    Signed-off-by: Mathias Krause <mathias.krause at secunet.com>
 util/inteltool/cpu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c
index e79380a..9037d5d 100644
--- a/util/inteltool/cpu.c
+++ b/util/inteltool/cpu.c
@@ -32,7 +32,7 @@ unsigned int cpuid(unsigned int op)
 	uint32_t ret;
-#if defined(__DARWIN__) && !defined(__LP64__)
+#if defined(__PIC__) || defined(__DARWIN__) && !defined(__LP64__)
 	asm volatile (
 		"pushl %%ebx\n"

More information about the coreboot mailing list