[coreboot] Patch set updated for coreboot: c7b3404 sb800: hide unused gpp ports

Kerry Sheh (shekairui@gmail.com) gerrit at coreboot.org
Wed Sep 14 03:58:42 CEST 2011


Kerry Sheh (shekairui at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/207

-gerrit

commit c7b34042bcb2080ed22f8f258045940e02c4ab5f
Author: Kerry Sheh <shekairui at gmail.com>
Date:   Wed Sep 14 10:19:46 2011 +0800

    sb800: hide unused gpp ports
    
    add a configure option SB_GPP_UNHIDE_PORTS to hide the unused gpp ports,
    if certain gpp port is not configured as hotplug and no device on the port,
    the port will be hidden. hidden unused ports make lspci -vvv get more
    accurate information under Linux, test on avalue/eax-785e.
    
    Change-Id: I1d7df0f2ab6ad69b1b99b8bf046411ae7cdb09c0
    Signed-off-by: Kerry Sheh <kerry.she at amd.com>
    Signed-off-by: Kerry Sheh <shekairui at gmail.com>
---
 src/mainboard/advansus/a785e-i/platform_cfg.h |    6 ++++++
 src/mainboard/amd/inagua/platform_cfg.h       |    6 ++++++
 src/mainboard/amd/persimmon/platform_cfg.h    |    6 ++++++
 src/mainboard/asrock/e350m1/platform_cfg.h    |    6 ++++++
 src/southbridge/amd/cimx/sb800/cfg.c          |    2 +-
 5 files changed, 25 insertions(+), 1 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/platform_cfg.h b/src/mainboard/advansus/a785e-i/platform_cfg.h
index ee68386..5fd49d6 100644
--- a/src/mainboard/advansus/a785e-i/platform_cfg.h
+++ b/src/mainboard/advansus/a785e-i/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/amd/inagua/platform_cfg.h b/src/mainboard/amd/inagua/platform_cfg.h
index d37c7e6..ed761c4 100644
--- a/src/mainboard/amd/inagua/platform_cfg.h
+++ b/src/mainboard/amd/inagua/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index c6d2bd5..5c88719 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h
index 3267651..201d107 100644
--- a/src/mainboard/asrock/e350m1/platform_cfg.h
+++ b/src/mainboard/asrock/e350m1/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2			TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS		FALSE
 
 /**
  * @def   GEC_CONFIG
diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c
index 45a460b..3245449 100644
--- a/src/southbridge/amd/cimx/sb800/cfg.c
+++ b/src/southbridge/amd/cimx/sb800/cfg.c
@@ -110,7 +110,7 @@ void sb800_cimx_config(AMDSBCFG *sb_config)
 	sb_config->PORTCONFIG[1].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
 	sb_config->PORTCONFIG[2].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
 	sb_config->PORTCONFIG[3].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
-	sb_config->GppUnhidePorts = TRUE; //visable always, even port empty
+	sb_config->GppUnhidePorts = SB_GPP_UNHIDE_PORTS;
 	sb_config->NbSbGen2 = NB_SB_GEN2;
 	sb_config->GppGen2 = SB_GPP_GEN2;
 




More information about the coreboot mailing list