[coreboot] New patch to review for coreboot: 684b764 sb800: IDE configure fix

Kerry Sheh (shekairui@gmail.com) gerrit at coreboot.org
Thu Sep 22 12:48:35 CEST 2011


Kerry Sheh (shekairui at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/228

-gerrit

commit 684b764eac0dba6de7cf86510e02ddf5b671679a
Author: Kerry Sheh <shekairui at gmail.com>
Date:   Thu Sep 22 18:56:42 2011 +0800

    sb800: IDE configure fix
    
    Using micro CIMX_OPTION_ENABLED/CIMX_OPTION_DISABLED to configure SataIdeCombinedMode is wrong.
    This code need to be removed.
    
    Change-Id: I8664a104bd0432b8dfbdaa9a1464c25e9f8ac963
    Signed-off-by: Kerry Sheh <kerry.she at amd.com>
    Signed-off-by: Kerry Sheh <shekairui at gmail.com>
---
 src/southbridge/amd/cimx/sb800/late.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index b581212..eb78546 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -343,11 +343,6 @@ static void sb800_enable(device_t dev)
 		break;
 
 	case (0x14 << 3) | 1: /* 0:14:1 IDE */
-		if (dev->enabled) {
-			sb_config->SATAMODE.SataMode.SataIdeCombinedMode = CIMX_OPTION_ENABLED;
-		} else {
-  			sb_config->SATAMODE.SataMode.SataIdeCombinedMode = CIMX_OPTION_DISABLED;
-		}
 		break;
 
 	case (0x14 << 3) | 2: /* 0:14:2 HDA */




More information about the coreboot mailing list