[coreboot] New patch to review for coreboot: a928a36 Removed repeated sections of code in header file

Vikram Narayanan (vikram186@gmail.com) gerrit at coreboot.org
Mon Apr 9 20:47:24 CEST 2012

Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/881


commit a928a367944580ed22a27ad5ad9de1ae2a17abde
Author: Vikram Narayanan <vikram186 at gmail.com>
Date:   Sat Feb 11 21:44:10 2012 +0530

    Removed repeated sections of code in header file
    Change-Id: Ia25e554dc2b4885b0470d250efb8b71671e47adb
    Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
 src/include/cpu/amd/amdfam12.h |   32 ++------------------------------
 1 files changed, 2 insertions(+), 30 deletions(-)

diff --git a/src/include/cpu/amd/amdfam12.h b/src/include/cpu/amd/amdfam12.h
index cabd532..db83821 100644
--- a/src/include/cpu/amd/amdfam12.h
+++ b/src/include/cpu/amd/amdfam12.h
@@ -20,35 +20,7 @@
 #ifndef CPU_AMD_FAM12_H
 #define CPU_AMD_FAM12_H
-#include <cpu/x86/msr.h>
-#define HWCR_MSR			0xC0010015
-#define NB_CFG_MSR			0xC001001f
-#define LS_CFG_MSR			0xC0011020
-#define IC_CFG_MSR			0xC0011021
-#define DC_CFG_MSR			0xC0011022
-#define BU_CFG_MSR			0xC0011023
-#define BU_CFG2_MSR			0xC001102A
-#define CPU_ID_FEATURES_MSR		0xC0011004
-#define CPU_ID_EXT_FEATURES_MSR	0xC0011005
-msr_t rdmsr_amd(u32 index);
-void wrmsr_amd(u32 index, msr_t msr);
-//#if defined(__GNUC__)
-//// it can be used to get unitid and coreid it running only
-//struct node_core_id get_node_core_id(u32 nb_cfg_54);
-//struct node_core_id get_node_core_id_x(void);
-#if defined(__PRE_RAM__)
-void wait_all_core0_started(void);
-void wait_all_other_cores_started(u32 bsp_apicid);
-void wait_all_aps_started(u32 bsp_apicid);
-void allow_all_aps_stop(u32 bsp_apicid);
-void get_bus_conf(void);
-u32 get_initial_apicid(void);
+/* As this file has the same contents as amdfam14.h, it is included here */
+#include <cpu/amd/amdfam14.h>
 #endif /* CPU_AMD_FAM12_H */

More information about the coreboot mailing list