[coreboot] Patch merged into coreboot/master: a408915 x86emu: fix jump_near_IMM to handle DATA: flag correctly

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 2 14:43:14 CEST 2012

the following patch was just integrated into master:
commit a408915a1c9d323a0735778ab72a0842b82c9df5
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Thu Jul 26 15:48:17 2012 -0700

    x86emu: fix jump_near_IMM to handle DATA: flag correctly
    Before (data flag ignored -> broken):
    66                  DATA:
    e944f1              JMP       1ff6
    After (fixed):
    66                  DATA:
    e944f1ffff          JMP       00001ff8
    This subtle difference in the length of decoded instruction meant
    that the VBE call jumped to the routine setting AX=0x14F (VBE Failed)
    instead of the routine that set AX=0x4F (VBE success).
    The ability to run the same code in vm86 significantly aided the
    debugging of this issue. Those X.org developers who would like to drop
    vm86 better take special care towards _all_ vesa bugs, as those will
    expose further issues.
    Imported from:
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Change-Id: Id08ead9b17468cf19ede45508e5dcc50e45b5acf
    Signed-off-by: Luc Verhaegen <libv at skynet.be>
    Tested-by: Luc Verhaegen <libv at skynet.be>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Signed-off-by: Keith Packard <keithp at keithp.com>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Thu Aug  2 14:43:12 2012, giving +2
See http://review.coreboot.org/1365 for details.


More information about the coreboot mailing list