[coreboot] New patch to review for coreboot: 1400723 AMD f15 nb: Remove the misleading 0x100 from the limitk (Propagation)

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Fri Aug 3 08:12:10 CEST 2012


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1404

-gerrit

commit 14007235fe60e386584d75148ae9c65cabcae577
Author: zbao <fishbaozi at gmail.com>
Date:   Fri Aug 3 15:56:21 2012 +0800

    AMD f15 nb: Remove the misleading 0x100 from the limitk (Propagation)
    
    Apply the change
    http://review.coreboot.org/1265
    to all the AMD northbridge.
    
    Change-Id: Idf3994c1e9ec76cd19db9f740d825cf24059884f
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>
---
 src/northbridge/amd/agesa/family15/northbridge.c   |    4 ++--
 src/northbridge/amd/agesa/family15tn/northbridge.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c
index 8d64a30..d7e9521 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.c
+++ b/src/northbridge/amd/agesa/family15/northbridge.c
@@ -619,7 +619,7 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
 				mem_hole.node_id = i;
 				break; //only one hole
 			}
-			limit_k = ((resource_t)((d.mask + 0x00000100) & 0x1fffff00)) << 9;
+			limit_k = ((resource_t)(((d.mask & ~1) + 0x000FF) & 0x1fffff00)) << 9;
 			limitk_pri = limit_k;
 		}
 	}
@@ -779,7 +779,7 @@ static void domain_set_resources(device_t dev)
 
 		if (!(d.mask & 1)) continue;
 		basek = ((resource_t)(d.base & 0x1fffff00)) << 9; // could overflow, we may lost 6 bit here
-		limitk = ((resource_t)((d.mask + 0x00000100) & 0x1fffff00)) << 9 ;
+		limitk = ((resource_t)(((d.mask & ~1) + 0x000FF) & 0x1fffff00)) << 9;
 
 		sizek = limitk - basek;
 
diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c
index 7f8650c..c63890d 100644
--- a/src/northbridge/amd/agesa/family15tn/northbridge.c
+++ b/src/northbridge/amd/agesa/family15tn/northbridge.c
@@ -628,7 +628,7 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
 				mem_hole.node_id = i;
 				break; //only one hole
 			}
-			limit_k = ((resource_t)((d.mask + 0x00000100) & 0x1fffff00)) << 9;
+			limit_k = ((resource_t)(((d.mask & ~1) + 0x000FF) & 0x1fffff00)) << 9;
 			limitk_pri = limit_k;
 		}
 	}




More information about the coreboot mailing list