[coreboot] Patch set updated for coreboot: 0358c7b ioapic driver: typedef the ioapic_config struct (TRIVIAL)

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sat Aug 25 00:01:54 CEST 2012

Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1481


commit 0358c7bd6e8bedfe309609950989576814ac36c3
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Aug 22 19:12:49 2012 -0500

    ioapic driver: typedef the ioapic_config struct (TRIVIAL)
    I use the ioapic_config in my VX900 branch.
    struct drivers_generic_ioapic_config *config = (struct drivers_generic_ioapic_config *)dev->chip_info;
    is clumsy at best, so just create a typedef to mahe this more elegant:
    ioapic_config_t config = (ioapic_config_t*)ioapic->chip_info;
    Change-Id: I407899845cfbd847ba6309dd0cf9ef836a607c8e
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
 src/drivers/generic/ioapic/chip.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/drivers/generic/ioapic/chip.h b/src/drivers/generic/ioapic/chip.h
index ad6ff0b..0936d63 100644
--- a/src/drivers/generic/ioapic/chip.h
+++ b/src/drivers/generic/ioapic/chip.h
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  * Copyright (C) 2011 Sven Schnelle <svens at stackframe.org>
+ * Copyright (C) 2012  Alexandru Gagniuc <mr.nuke.me at gmail.com>
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -20,12 +21,13 @@
-struct drivers_generic_ioapic_config {
+typedef struct drivers_generic_ioapic_config {
 	u32 version;
 	u8 apicid;
 	u8 irq_on_fsb;
 	u8 enable_virtual_wire;
 	u8 have_isa_interrupts;
 	u32 base;
+} ioapic_config_t;

More information about the coreboot mailing list