[coreboot] New patch to review for coreboot: d484f21 Fix a compare against undefined variable in acpi.c
Martin Roth (martin@se-eng.com)
gerrit at coreboot.org
Sat Dec 15 03:21:59 CET 2012
Martin Roth (martin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2037
-gerrit
commit d484f211eb94146e964e53cd92e4dc2c691bef3e
Author: Martin Roth <martin at se-eng.com>
Date: Fri Dec 14 19:17:55 2012 -0700
Fix a compare against undefined variable in acpi.c
Initialize the pointer fadt to NULL to prevent a later comparison
(if (fadt == NULL)) when the pointer had the *possibility* of never
having been initialized.
Change-Id: Ib2a544c190b609ab8c23147dc69dca5f4ac7f38c
Signed-off-by: Martin Roth <martin at se-eng.com>
---
src/arch/x86/boot/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/boot/acpi.c b/src/arch/x86/boot/acpi.c
index fd6a1ba..1d7dbf8 100644
--- a/src/arch/x86/boot/acpi.c
+++ b/src/arch/x86/boot/acpi.c
@@ -687,7 +687,7 @@ void *acpi_find_wakeup_vector(void)
char *p, *end;
acpi_rsdt_t *rsdt;
acpi_facs_t *facs;
- acpi_fadt_t *fadt;
+ acpi_fadt_t *fadt = NULL;
void *wake_vec;
int i;
More information about the coreboot
mailing list