[coreboot] New patch to review for coreboot: 2b607f7 add a return type to test function used by xcompile

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Fri Dec 21 06:23:07 CET 2012

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2068


commit 2b607f79fca8400bc5c7730b7d60e6dc23b02151
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Dec 20 14:24:08 2012 -0800

    add a return type to test function used by xcompile
    This fixes a minor bug that could cause testcc to fail unexpectedly.
    Change-Id: Ib75d343104b6937682c05acf5232596aac83f105
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 util/xcompile/xcompile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index fdc5213..4239176 100644
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -40,7 +40,7 @@ testcc() {
 	local tmp_c="$TMPFILE.c"
 	local tmp_o="$TMPFILE.o"
 	rm -f "$tmp_c" "$tmp_o"
-	echo "_start(void) {}" >"$tmp_c"
+	echo "void _start(void) {}" >"$tmp_c"
 	"$1" -nostdlib -Werror $2 "$tmp_c" -o "$tmp_o" >/dev/null 2>&1

More information about the coreboot mailing list