[coreboot] New patch to review for coreboot: 6d9bab8 move iRAM config variable to exynos5250 Kconfig

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Thu Dec 27 23:10:42 CET 2012


David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2077

-gerrit

commit 6d9bab8bc870c938f8f62a056ce6d585b630ea39
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Dec 27 13:50:32 2012 -0800

    move iRAM config variable to exynos5250 Kconfig
    
    Since these don't seem very generic and depend on the BL1, let's
    move them to the CPU-specific Kconfig.
    
    Change-Id: I33059b7db30d35a1853918a580f312e50a3499fa
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 src/cpu/samsung/Kconfig            | 26 --------------------------
 src/cpu/samsung/exynos5250/Kconfig | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 26 deletions(-)

diff --git a/src/cpu/samsung/Kconfig b/src/cpu/samsung/Kconfig
index 3a14ab8..4a09ca3 100644
--- a/src/cpu/samsung/Kconfig
+++ b/src/cpu/samsung/Kconfig
@@ -15,32 +15,6 @@ config SKIP_LOWLEVEL_INIT
 	  Certain functions (ie PLL init) and processor features may already be
 	  handled by masked ROM code.
 
-config IRAM_BOTTOM
-	hex
-	default 0x02020000
-
-# FIXME(dhendrix): 0x02050000 was in the u-boot sources, but the docs say the
-# iRAM range is 0x0202_0000 - 0x0207_7fff (352KB).
-#config IRAM_TOP
-#	hex
-#	default 0x02050000
-config IRAM_TOP
-	hex
-	default 0x02077fff
-
-config SYS_INIT_SP_ADDR
-	hex
-	default 0x0204F800
-
-config IRAM_STACK
-	hex
-	default SYS_INIT_SP_ADDR
-
-# FIXME(dhendrix): what should this really be?
-config XIP_ROM_SIZE
-	hex
-	default 0x20000
-
 if CPU_SAMSUNG_EXYNOS5
 source src/cpu/samsung/exynos5250/Kconfig
 endif
diff --git a/src/cpu/samsung/exynos5250/Kconfig b/src/cpu/samsung/exynos5250/Kconfig
index 8d4ba2d..b51a127 100644
--- a/src/cpu/samsung/exynos5250/Kconfig
+++ b/src/cpu/samsung/exynos5250/Kconfig
@@ -26,3 +26,27 @@ config RAMBASE
 config RAMTOP
 	hex
 	default 0x40100000
+
+# FIXME 1: According to the Exynos5250 datasheet, the iRAM range is
+# 0x0202_0000 to 0x0207_7fff (352KB). However, it appears that we are
+# actually constrained by whatever region BL1 sets up for us.
+config IRAM_BOTTOM
+	hex
+#	default 0x02020000
+	default 0x02023400
+
+config IRAM_TOP
+	hex
+	default 0x02077fff
+
+config SYS_INIT_SP_ADDR
+	hex
+	default 0x0204F800
+
+config IRAM_STACK
+	hex
+	default SYS_INIT_SP_ADDR
+
+config XIP_ROM_SIZE
+	hex "ROM stage (BL2) size"
+	default 0x4000



More information about the coreboot mailing list