[coreboot] New patch to review for coreboot: 5326f5c gitconfig: Add lint-stable as pre-commit hook

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Feb 25 19:50:27 CET 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/682


commit 5326f5c7e6a9d56bc0f030c81651050d6d280150
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Feb 25 19:52:45 2012 +0100

    gitconfig: Add lint-stable as pre-commit hook
    When configuring the tree with "make gitconfig", a pre-commit hook
    is installed that runs the stable lint tests.
    If any of these fail, the log is visible (on stdout) and the
    commit is aborted.
    Change-Id: Ie2a26e87f466c63b24db8dca8827057a18ac7f3e
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 Makefile.inc              |    2 +-
 util/gitconfig/pre-commit |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 0f040e9..2f61a45 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -239,7 +239,7 @@ lint lint-stable:
 	rm -f $$LINTLOG
-	if ! [ -x .git/hooks/commit-msg ]; then cp util/gitconfig/commit-msg .git/hooks/commit-msg; chmod +x .git/hooks/commit-msg; fi
+	for hook in commit-msg pre-commit; do if ! [ -x .git/hooks/$$hook ]; then cp util/gitconfig/$$hook .git/hooks/$$hook; chmod +x .git/hooks/$$hook; fi; done
 	(git config --global user.name >/dev/null && git config --global user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email at example.com\n'; exit 1)
 crossgcc: clean-for-update
diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit
new file mode 100755
index 0000000..8ab3e56
--- /dev/null
+++ b/util/gitconfig/pre-commit
@@ -0,0 +1,2 @@
+exec make lint-stable

More information about the coreboot mailing list