[coreboot] New patch to review for coreboot: dd17846 Fix x86 cpu_phys_address_size
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Wed Feb 29 20:22:16 CET 2012
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/688
-gerrit
commit dd17846e4422969c9915bd0d31ebb3769059f80a
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Wed Feb 29 21:17:18 2012 +0200
Fix x86 cpu_phys_address_size
After CPUID, requested feature flag is in edx, not eax.
Change-Id: I9ce27c22186f17cc64986be342d7d1ac78a79898
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/arch/x86/lib/cpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/arch/x86/lib/cpu.c b/src/arch/x86/lib/cpu.c
index ada57e2..8aacaac 100644
--- a/src/arch/x86/lib/cpu.c
+++ b/src/arch/x86/lib/cpu.c
@@ -147,7 +147,7 @@ int cpu_phys_address_size(void)
if (cpu_cpuid_extended_level() >= 0x80000008)
return cpuid_eax(0x80000008) & 0xff;
- if (cpuid_eax(1) & (CPUID_FEATURE_PAE | CPUID_FEATURE_PSE36))
+ if (cpuid_edx(1) & (CPUID_FEATURE_PAE | CPUID_FEATURE_PSE36))
return 36;
return 32;
}
More information about the coreboot
mailing list