[coreboot] New patch to review for coreboot: 9faab44 adm1027: add return statement

Vikram Narayanan (vikram186@gmail.com) gerrit at coreboot.org
Sat Jan 7 11:44:05 CET 2012

Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/522


commit 9faab4477efb6d0102c9854dcc1ecd3f1cac6421
Author: Vikram Narayanan <vikram186 at gmail.com>
Date:   Sat Jan 7 16:04:46 2012 +0530

    adm1027: add return statement
    Adds a missing return statment which will stop misleading the users
    Change-Id: I53741f1136b396e9493ce959b54efc00c9b09764
    Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
 src/drivers/i2c/adm1027/adm1027.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c
index 516a889..e97ec69 100644
--- a/src/drivers/i2c/adm1027/adm1027.c
+++ b/src/drivers/i2c/adm1027/adm1027.c
@@ -35,6 +35,7 @@ static void adm1027_enable_monitoring(device_t dev)
 	result = smbus_read_byte(dev, ADM1027_REG_CONFIG1);
 	if (!(result & CFG1_STRT)) {
 		printk(BIOS_DEBUG, "ADM1027: monitoring would not enable\n");
+		return;
 	printk(BIOS_DEBUG, "ADM1027: monitoring enabled\n");

More information about the coreboot mailing list