[coreboot] New patch to review for coreboot: 956045c adm1026: removed prototype

Vikram Narayanan (vikram186@gmail.com) gerrit at coreboot.org
Sat Jan 21 11:05:20 CET 2012


Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/570

-gerrit

commit 956045c67dc71e493f76ada4586bd1145fdad572
Author: Vikram Narayanan <vikram186 at gmail.com>
Date:   Sat Jan 21 15:32:59 2012 +0530

    adm1026: removed prototype
    
    Removed the prototype and restructured the code
    
    Change-Id: I13a648acf7bae30635e0469e301ce5635d9d7a8c
    Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
---
 src/drivers/i2c/adm1026/adm1026.c |   24 +++++++++++-------------
 1 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c
index 1aaae52..5b06629 100644
--- a/src/drivers/i2c/adm1026/adm1026.c
+++ b/src/drivers/i2c/adm1026/adm1026.c
@@ -20,19 +20,6 @@
 #define ADM1026_REG_CONFIG2 0x01
 #define ADM1026_REG_CONFIG3 0x07
 
-static void adm1026_enable_monitoring(device_t dev);
-
-static void adm1026_init(device_t dev)
-{
-	if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) {
-		if (ops_smbus_bus(get_pbus_smbus(dev))) {
-			if (dev->bus->dev->path.type == DEVICE_PATH_I2C)
-				smbus_set_link(dev);	// it is under mux
-			adm1026_enable_monitoring(dev);
-		}
-	}
-}
-
 static void adm1026_enable_monitoring(device_t dev)
 {
 	int result;
@@ -47,6 +34,17 @@ static void adm1026_enable_monitoring(device_t dev)
 	}
 }
 
+static void adm1026_init(device_t dev)
+{
+	if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) {
+		if (ops_smbus_bus(get_pbus_smbus(dev))) {
+			if (dev->bus->dev->path.type == DEVICE_PATH_I2C)
+				smbus_set_link(dev);	// it is under mux
+			adm1026_enable_monitoring(dev);
+		}
+	}
+}
+
 static void adm1026_noop(device_t dummy)
 {
 }




More information about the coreboot mailing list