[coreboot] Patch set updated for coreboot: f74ca42 pci_ops_mmconf: Move conditional compilation to Makefile

Vikram Narayanan (vikram186@gmail.com) gerrit at coreboot.org
Thu Jan 26 07:38:08 CET 2012


Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/578

-gerrit

commit f74ca42fc8462f791fdb2866919625a8f6459e1d
Author: Vikram Narayanan <vikram186 at gmail.com>
Date:   Tue Jan 24 20:22:20 2012 +0530

    pci_ops_mmconf: Move conditional compilation to Makefile
    
    Moved the conditional compilation out of the source file
    
    Change-Id: Ic4045006f39d70f4a0bc37d1bd5e073ed8477c68
    Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
---
 src/arch/x86/lib/Makefile.inc     |    4 +++-
 src/arch/x86/lib/pci_ops_mmconf.c |    4 ----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/arch/x86/lib/Makefile.inc b/src/arch/x86/lib/Makefile.inc
index 3092388..3388a9d 100644
--- a/src/arch/x86/lib/Makefile.inc
+++ b/src/arch/x86/lib/Makefile.inc
@@ -2,7 +2,9 @@ ramstage-y += c_start.S
 ramstage-y += cpu.c
 ramstage-y += pci_ops_conf1.c
 ramstage-y += pci_ops_conf2.c
-ramstage-y += pci_ops_mmconf.c
+
+ramstage-$(CONFIG_MMCONF_SUPPORT) += pci_ops_mmconf.c
+
 ramstage-y += pci_ops_auto.c
 ramstage-y += exception.c
 ramstage-$(CONFIG_IOAPIC) += ioapic.c
diff --git a/src/arch/x86/lib/pci_ops_mmconf.c b/src/arch/x86/lib/pci_ops_mmconf.c
index 7fcd88a..4f9d826 100644
--- a/src/arch/x86/lib/pci_ops_mmconf.c
+++ b/src/arch/x86/lib/pci_ops_mmconf.c
@@ -1,5 +1,3 @@
-#if CONFIG_MMCONF_SUPPORT
-
 #include <console/console.h>
 #include <arch/io.h>
 #include <arch/pciconf.h>
@@ -63,5 +61,3 @@ const struct pci_bus_operations pci_ops_mmconf = {
 	.write16 = pci_mmconf_write_config16,
 	.write32 = pci_mmconf_write_config32,
 };
-
-#endif




More information about the coreboot mailing list