[coreboot] New patch to review for coreboot: 43c9618 Fix the CPU index parameter passed to secondary_cpu_init().

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jul 5 06:11:14 CEST 2012

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1173


commit 43c9618eaf9e9c0455020040c47eb4cf74e93329
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu Jul 5 06:30:29 2012 +0300

    Fix the CPU index parameter passed to secondary_cpu_init().
    Count 0,1,2,3,... instead of 0,2,3,4,...
    Change-Id: I3c6b85e5e71b32deac5470809e1618d28f19c00f
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
 src/cpu/x86/lapic/secondary.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/cpu/x86/lapic/secondary.S b/src/cpu/x86/lapic/secondary.S
index 67e44c4..2ad7029 100644
--- a/src/cpu/x86/lapic/secondary.S
+++ b/src/cpu/x86/lapic/secondary.S
@@ -41,8 +41,8 @@ _secondary_start:
 	/* increment our cpu index */
 	movl	$1, %eax
 	lock	xadd %eax, cpucount
-	incl	%eax
 	movl	%eax, %ecx
+	incl	%eax
 	/* assign stack for this specific cpu */
 	mov	_stack, %esp

More information about the coreboot mailing list