[coreboot] New patch to review for coreboot: ef80d93 Fix APIC cpu_index

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Jul 10 09:33:14 CEST 2012

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1199


commit ef80d93df0878bb61325ebee312614263660d9aa
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Jul 10 10:19:40 2012 +0300

    Fix APIC cpu_index
    If a CPU was pre-allocated, cpu_path is not copied and thus
    index would not be updated. This breaks cpu_index() and AMD
    model_fxx is possibly broken without this patch.
    Change-Id: I77483181cf0bca31423c655942c022bffab3c7ea
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
 src/arch/x86/lib/cpu.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/arch/x86/lib/cpu.c b/src/arch/x86/lib/cpu.c
index 5214abe..7cd955e 100644
--- a/src/arch/x86/lib/cpu.c
+++ b/src/arch/x86/lib/cpu.c
@@ -249,9 +249,10 @@ void cpu_initialize(struct bus *cpu_bus, int index)
 	cpu_path.type = DEVICE_PATH_APIC;
 	cpu_path.apic.apic_id = id;
-	cpu_path.apic.index = index;
 	cpu = alloc_find_dev(cpu_bus, &cpu_path);
+	cpu->path.apic.index = index;
 	printk(BIOS_DEBUG, "Initializing CPU #%d\n", id);
 	/* Find what type of cpu we are dealing with */

More information about the coreboot mailing list