[coreboot] New patch to review for coreboot: 8e599ec Print PCI ID of PCH during boot up

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Jul 23 23:21:09 CEST 2012

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1287


commit 8e599ec930891a7d93a0830b466f15a3d4d084fe
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Jun 18 11:26:25 2012 -0700

    Print PCI ID of PCH during boot up
    Right now, if we have an unknown PCH, coreboot will print something like
    PCH type: Unknown rev id 4
    Instead, it should also print the PCI ID of the device, so we can add it
    to the list of known PCHes.
    Change-Id: Ib0b96e287c36d2895d1287b1734ca13d75e7985a
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 .../intel/sandybridge/report_platform.c            |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/report_platform.c b/src/northbridge/intel/sandybridge/report_platform.c
index d59cfe9..18dffc2 100644
--- a/src/northbridge/intel/sandybridge/report_platform.c
+++ b/src/northbridge/intel/sandybridge/report_platform.c
@@ -92,8 +92,8 @@ static void report_pch_info(void)
-	printk (BIOS_DEBUG, "PCH type: %s rev id %x\n",
-		pch_type, pci_read_config8(PCH_LPC_DEV, 8));
+	printk (BIOS_DEBUG, "PCH type: %s, device id: %x, rev id %x\n",
+		pch_type, dev_id, pci_read_config8(PCH_LPC_DEV, 8));
 void report_platform_info(void)

More information about the coreboot mailing list