[coreboot] New patch to review for coreboot: 6fd9d3d Remove CMOS Extended range enable from romstage

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jul 24 00:12:36 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1307

-gerrit

commit 6fd9d3d47fb049b5a6004af399177e6c17782265
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Jun 25 10:39:21 2012 -0700

    Remove CMOS Extended range enable from romstage
    
    This enable step has been moved to the bd82x6x bootblock.
    
    For Samsung Stumpy and Lumpy mainboards and the
    Intel EmeraldLake2 reference board.
    
    Change-Id: I5ce54f57b8e1dd732c8a5ae71d7511703de91a0e
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/intel/emeraldlake2/romstage.c |    3 ---
 src/mainboard/samsung/lumpy/romstage.c      |    3 ---
 src/mainboard/samsung/stumpy/romstage.c     |    3 ---
 3 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c
index f8ef17d..7a31242 100644
--- a/src/mainboard/intel/emeraldlake2/romstage.c
+++ b/src/mainboard/intel/emeraldlake2/romstage.c
@@ -113,9 +113,6 @@ static void rcba_config(void)
 	/* PCH BWG says to read back the IOAPIC enable register */
 	(void) RCBA16(OIC);
 
-	/* Enable upper 128bytes of CMOS (generic) */
-	RCBA32(RC) = (1 << 2);
-
 	/* Disable unused devices (board specific) */
 	reg32 = RCBA32(FD);
 	reg32 |= PCH_DISABLE_ALWAYS;
diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c
index 09cbd2a..4bba76e 100644
--- a/src/mainboard/samsung/lumpy/romstage.c
+++ b/src/mainboard/samsung/lumpy/romstage.c
@@ -114,9 +114,6 @@ static void rcba_config(void)
 	/* PCH BWG says to read back the IOAPIC enable register */
 	(void) RCBA16(OIC);
 
-	/* Enable upper 128bytes of CMOS (generic) */
-	RCBA32(RC) = (1 << 2);
-
 	/* Disable unused devices (board specific) */
 	reg32 = RCBA32(FD);
 	reg32 |= PCH_DISABLE_ALWAYS;
diff --git a/src/mainboard/samsung/stumpy/romstage.c b/src/mainboard/samsung/stumpy/romstage.c
index 68f6260..58305c8 100644
--- a/src/mainboard/samsung/stumpy/romstage.c
+++ b/src/mainboard/samsung/stumpy/romstage.c
@@ -119,9 +119,6 @@ static void rcba_config(void)
 	/* PCH BWG says to read back the IOAPIC enable register */
 	(void) RCBA16(OIC);
 
-	/* Enable upper 128bytes of CMOS (generic) */
-	RCBA32(RC) = (1 << 2);
-
 	/* Disable unused devices (board specific) */
 	reg32 = RCBA32(FD);
 	reg32 |= PCH_DISABLE_ALWAYS;




More information about the coreboot mailing list