[coreboot] Patch merged into coreboot/master: 4e390b1 Change multiply ONE_MB to bit shifting.

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 25 22:15:18 CEST 2012

the following patch was just integrated into master:
commit 4e390b13b760ca44be993d40fc653bfcb487588c
Author: zbao <fishbaozi at gmail.com>
Date:   Mon Jul 23 19:44:29 2012 +0800

    Change multiply ONE_MB to bit shifting.
    2048 * ONE_MB will cause warning,
    src/northbridge/amd/agesa/family15tn/northbridge.c:667:50: warning: integer overflow in expression [-Woverflow]
    I guess it will change the data type to signed integer.
    I think the bit shifting is better.
    Change-Id: I823f7ead1f7d622bf653cb3bf2ae2343f5e76805
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>

Build-Tested: build bot (Jenkins) at Mon Jul 23 12:46:49 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Wed Jul 25 22:15:17 2012, giving +2
See http://review.coreboot.org/1263 for details.


More information about the coreboot mailing list