[coreboot] Patch merged into coreboot/master: 96e5b66 AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE
gerrit at coreboot.org
gerrit at coreboot.org
Wed Jul 25 22:21:28 CEST 2012
the following patch was just integrated into master:
commit 96e5b66538e4ab0e38057212e25002070d77531e
Author: zbao <fishbaozi at gmail.com>
Date: Tue Jul 24 17:58:30 2012 +0800
AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE
The default return value should be AGESA_SUCCESS, which is zero. If it was set as TRUE,
the AGESA wrapper would think it was AGESA_UNSUPPORTED. That would make no sense. And it
would produce ASSERT warning in AGESA wrapper.
On my parmer board, with Engine sample processor, it can not create the correct DMI table.
Routine initlate will return AGESS_ERROR.
------Serial message---------
ASSERTION FAILED: file 'src/mainboard/amd/parmer/agesawrapper.c', line 427
DmiTable:100123c3, AcpiPstatein: 10010126, AcpiSrat:0,AcpiSlit:0, Mce:100111ba, Cmc:1001127c,Alib:1001ccd4, AcpiIvrs:0 in agesawrapper_amdinitlate
agesawrapper_amdinitlate failed: 5
-----------------------------
I believe the processor with acceptable name string will create the right DMI.
Change-Id: Ie86955cf9affffc964a7c9f4a2c63077ef2030de
Signed-off-by: Zheng Bao <zheng.bao at amd.com>
Signed-off-by: zbao <fishbaozi at gmail.com>
Build-Tested: build bot (Jenkins) at Wed Jul 25 06:02:07 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Jul 25 22:21:24 2012, giving +2
See http://review.coreboot.org/1350 for details.
-gerrit
More information about the coreboot
mailing list