[coreboot] New patch to review for coreboot: 7d2dd95 superiotool: Add support for NCT6775F and NCT6779D

Paul Menzel paulepanter at users.sourceforge.net
Fri Jun 29 21:52:48 CEST 2012


Dear Günter,


thank you for your patches.


Am Freitag, den 29.06.2012, 21:31 +0200 schrieb Guenter Roeck:
> Guenter Roeck (linux at roeck-us.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
> 
> -gerrit
> 
> commit 7d2dd956c42b0d043fae3167bc17471a26c131db
> Author: Guenter Roeck <linux at roeck-us.net>
> Date:   Fri Jun 29 12:22:51 2012 -0700
> 
>     superiotool: Add support for NCT6775F and NCT6779D

Maybe add A/B to the first chip so that it is clear that three chips are
added. (Next time a separate patch for each patch would be also nice I
think.)

Could you add send the output of `superiotool -V` for all three chips to
the *list*? Maybe as a reply to this status message. That would be
awesome.

Lastly, are the data sheets available somewhere?

>     Change-Id: I66667fcb58f6885460021f4a2024d6ba56b95f11
>     Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> ---
>  util/superiotool/nuvoton.c |  234 ++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 234 insertions(+), 0 deletions(-)

Otherwise this looks good. Thanks again.

[…]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20120629/eff65bc3/attachment.sig>


More information about the coreboot mailing list