[coreboot] New patch to review for coreboot: 484acec Include arch/acpi.h instead of manually adding acpi_slp_type.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Mar 6 00:52:39 CET 2012

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/714


commit 484acec01d2b55a648cf810ae37a8f405b529ba6
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Fri Sep 23 10:24:49 2011 -0700

    Include arch/acpi.h instead of manually adding acpi_slp_type.
    acpi_slp_type is defined in arch/acpi.h, so let's use that instead
    of manually spreading extern u8 acpi_slp_type throughout the code.
    Change-Id: Ia5eb420364c15ab5a764bc328bbd201ca9cb7837
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 src/lib/cbmem.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/lib/cbmem.c b/src/lib/cbmem.c
index 6597840..f800b04 100644
--- a/src/lib/cbmem.c
+++ b/src/lib/cbmem.c
@@ -21,6 +21,9 @@
 #include <string.h>
 #include <cbmem.h>
 #include <console/console.h>
+#if CONFIG_HAVE_ACPI_RESUME && !defined(__PRE_RAM__)
+#include <arch/acpi.h>
 // The CBMEM TOC reserves 512 bytes to keep
 // the other entries somewhat aligned.
@@ -199,10 +202,6 @@ void *cbmem_find(u32 id)
 	return (void *)NULL;
-#if CONFIG_HAVE_ACPI_RESUME && !defined(__PRE_RAM__)
-extern u8 acpi_slp_type;
 #if CONFIG_EARLY_CBMEM_INIT || !defined(__PRE_RAM__)
 /* Returns True if it was not intialized before. */
 int cbmem_initialize(void)

More information about the coreboot mailing list