[coreboot] Patch set updated for coreboot: 484a702 Fix romcc to compile cleanly

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Mar 7 20:22:49 CET 2012

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/759


commit 484a7021d3876b265039c8e242c48b2e7bf98a68
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Dec 6 22:14:57 2011 +0000

    Fix romcc to compile cleanly
    There have been many unused variable assignments in the romcc source
    file. They cause multiple warning messages during build process which
    in turn make it harder to see the actual error message, when they are
    The fix is to remove dead code and to add -Werror to romcc compilation
    to avoid issues like this creeping in in the future.
    Change-Id: I6f42684f39a4135b0fe64219b8c7f058275c9fee
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
 util/romcc/Makefile |    2 +-
 util/romcc/romcc.c  |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/util/romcc/Makefile b/util/romcc/Makefile
index 6543fbb..8242eb5 100644
--- a/util/romcc/Makefile
+++ b/util/romcc/Makefile
@@ -1,7 +1,7 @@
 # Move the configuration defines to makefile.conf
+CFLAGS= -g -Wall -Werror $(CPPFLAGS)
 CPROF_FLAGS=-pg -fprofile-arcs
 all: romcc test
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index c7ef223..7eee439 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -9161,8 +9161,7 @@ static void decompose_compound_types(struct compile_state *state)
 	struct triple *ins, *next, *first;
-	FILE *fp;
-	fp = state->dbgout;
+	FILE *fp = state->dbgout;
 	first = state->first;
 	ins = first;

More information about the coreboot mailing list