[coreboot] Patch set updated for coreboot: 8047e25 Add DEBUG_TPM option to Debugging menu

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Mar 8 20:03:58 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/757

-gerrit

commit 8047e25c46f84c4ef3b7cf5332c93d37bc0980cf
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Thu Nov 17 12:50:54 2011 -0800

    Add DEBUG_TPM option to Debugging menu
    
    instead of having to edit the source code of tpm.c
    
    Change-Id: I519d9ada14dd383e668a2da4219e5373a24c7c3d
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/Kconfig    |    7 +++++++
 src/pc80/tpm.c |    9 +--------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 26e6dde..41c5dbf 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -870,6 +870,13 @@ config X86EMU_DEBUG_IO
 
 	  If unsure, say N.
 
+config DEBUG_TPM
+	bool "Output verbose TPM debug messages"
+	default n
+	depends on TPM
+	help
+	  This option enables additional TPM related debug messages.
+
 config LLSHELL
 	bool "Built-in low-level shell"
 	default n
diff --git a/src/pc80/tpm.c b/src/pc80/tpm.c
index 8e94303..17e1ed7 100644
--- a/src/pc80/tpm.c
+++ b/src/pc80/tpm.c
@@ -27,7 +27,6 @@
  * Infineon slb9635), so this driver provides access to locality 0 only.
  */
 
-/* #define DEBUG */
 #include <stdlib.h>
 #include <string.h>
 #include <delay.h>
@@ -37,17 +36,11 @@
 #include <pc80/tpm.h>
 #include <cpu/x86/car.h>
 
-#ifdef DEBUG
-#define TPM_DEBUG_ON	1
-#else
-#define TPM_DEBUG_ON	0
-#endif
-
 #define PREFIX "lpc_tpm: "
 
 /* coreboot wrapper for TPM driver (start) */
 #define	TPM_DEBUG(fmt, args...)		\
-	if (TPM_DEBUG_ON) {		\
+	if (CONFIG_DEBUG_TPM) {		\
 		printk(BIOS_DEBUG, PREFIX);		\
 		printk(BIOS_DEBUG, fmt , ##args);	\
 	}




More information about the coreboot mailing list