[coreboot] New patch to review for coreboot: c876459 [ChromeOS] Don't initialize VGA Option ROM in normal mode

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Mar 31 02:29:56 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/829

-gerrit

commit c8764595acb4eca89ce7e6d2dabf7c6e8eac7704
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Fri Mar 30 17:10:49 2012 -0700

    [ChromeOS] Don't initialize VGA Option ROM in normal mode
    
    ChromeOS features two different modes: normal mode and developer mode
    (aka jailbreak mode). In developer mode, we need to display a warning
    screen for security reasons.
    
    However, in normal mode we want to boot blazingly fast. Therefore we
    don't run (VGA) option ROMs, unless we have to print something on the
    screen before the kernel is loaded.
    
    Change-Id: I37f63d0b082a48e037e65bde2b380f9b8743ed29
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/devices/pci_device.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/src/devices/pci_device.c b/src/devices/pci_device.c
index 0a870b8..c055995 100644
--- a/src/devices/pci_device.c
+++ b/src/devices/pci_device.c
@@ -54,6 +54,9 @@
 #if CONFIG_HAVE_ACPI_RESUME && !CONFIG_S3_VGA_ROM_RUN
 #include <arch/acpi.h>
 #endif
+#if CONFIG_CHROMEOS
+#include <vendorcode/google/chromeos/chromeos.h>
+#endif
 
 u8 pci_moving_config8(struct device *dev, unsigned int reg)
 {
@@ -667,6 +670,15 @@ void pci_dev_init(struct device *dev)
 	    ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA))
 		return;
 
+#if CONFIG_CHROMEOS
+	/* In ChromeOS we want to boot blazingly fast. Therefore
+	 * we don't run (VGA) option ROMs, unless we have to print
+	 * something on the screen before the kernel is loaded.
+	 */
+	if (!developer_mode_enabled() && !recovery_mode_enabled())
+		return;
+#endif
+
 	rom = pci_rom_probe(dev);
 	if (rom == NULL)
 		return;




More information about the coreboot mailing list