[coreboot] New patch to review for coreboot: 2badb25 Print some useful debugging information in PSS table creation

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu May 3 01:47:56 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/994

-gerrit

commit 2badb25677a0425f43f53ece4db187ec829fa659
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Wed May 2 16:38:47 2012 -0700

    Print some useful debugging information in PSS table creation
    
    Change-Id: I1ec7a7e54513671331ac12f08d5f59161b72b0fd
    Example:
    PSS: 1900MHz power 35000 control 0x1300 status 0x1300
    PSS: 1600MHz power 28468 control 0x1000 status 0x1000
    PSS: 1400MHz power 24291 control 0xe00 status 0xe00
    PSS: 1200MHz power 20340 control 0xc00 status 0xc00
    PSS: 1000MHz power 16569 control 0xa00 status 0xa00
    PSS: 800MHz power 12937 control 0x800 status 0x800
    PSS: 1900MHz power 35000 control 0x1300 status 0x1300
    PSS: 1600MHz power 28468 control 0x1000 status 0x1000
    PSS: 1400MHz power 24291 control 0xe00 status 0xe00
    PSS: 1200MHz power 20340 control 0xc00 status 0xc00
    PSS: 1000MHz power 16569 control 0xa00 status 0xa00
    PSS: 800MHz power 12937 control 0x800 status 0x800
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/arch/x86/boot/acpigen.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/arch/x86/boot/acpigen.c b/src/arch/x86/boot/acpigen.c
index 04aeddf..e7a297d 100644
--- a/src/arch/x86/boot/acpigen.c
+++ b/src/arch/x86/boot/acpigen.c
@@ -426,8 +426,12 @@ int acpigen_write_PSS_package(u32 coreFreq, u32 power, u32 transLat,
 	len += acpigen_write_dword(busmLat);
 	len += acpigen_write_dword(control);
 	len += acpigen_write_dword(status);
-	//pkglen without the len opcode
+	// pkglen without the len opcode
 	acpigen_patch_len(len - 1);
+
+	printk(BIOS_DEBUG, "PSS: %uMHz power %u control 0x%x status 0x%x\n",
+	       coreFreq, power, control, status);
+
 	return len;
 }
 




More information about the coreboot mailing list