[coreboot] New patch to review for coreboot: 856a155 sconfig: Some fixes

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Wed May 30 17:00:25 CEST 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1067

-gerrit

commit 856a15569d36eba648c8b9f544442703216a59a6
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Wed May 30 16:26:30 2012 +0200

    sconfig: Some fixes
    
    clang complained about a missing include and wrong fprintf use.
    
    Change-Id: Idc023b653e694147c624d5f8f9ed3b797c462e9f
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/sconfig/main.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index 181be38..5d97274 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -18,6 +18,7 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA
  */
 
+#include <ctype.h>
 #include "sconfig.h"
 #include "sconfig.tab.h"
 
@@ -336,7 +337,7 @@ static void pass0(FILE *fil, struct device *ptr) {
 static void pass1(FILE *fil, struct device *ptr) {
 	if (!ptr->used && (ptr->type == device)) {
 		if (ptr->id != 0)
-			fprintf(fil, "static ", ptr->name);
+			fprintf(fil, "static ");
 		fprintf(fil, "struct device %s = {\n", ptr->name);
 		fprintf(fil, "\t.ops = %s,\n", (ptr->ops)?(ptr->ops):"0");
 		fprintf(fil, "\t.bus = &%s_links[%d],\n", ptr->bus->name, ptr->bus->link);
@@ -358,7 +359,7 @@ static void pass1(FILE *fil, struct device *ptr) {
 		if (ptr->children || ptr->multidev)
 			fprintf(fil, "\t.link_list = &%s_links[0],\n", ptr->name);
 		else
-			fprintf(fil, "\t.link_list = NULL,\n", ptr->name);
+			fprintf(fil, "\t.link_list = NULL,\n");
 		if (ptr->sibling)
 			fprintf(fil, "\t.sibling = &%s,\n", ptr->sibling->name);
 		if (ptr->chip->chiph_exists) {




More information about the coreboot mailing list