[coreboot] New patch to review for coreboot: 0e7d59e ELOG: Don't disable SPI controller lockdown

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Nov 6 23:51:59 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1712

-gerrit

commit 0e7d59ed7b6a456009f174bd5f98d4b8f31d8518
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Aug 27 13:51:23 2012 -0700

    ELOG: Don't disable SPI controller lockdown
    
    Now that WREN prefix is handled properly ELOG is able to write
    when the SPI controller is locked down.
    
    To test, ensure that runtime SPI write via ELOG is successful by
    checking the event log for a kernel shutdown reason code:
    
    5 | 2012-08-27 11:09:48 | Kernel Event | Clean Shutdown
    6 | 2012-08-27 11:09:50 | System boot | 26
    7 | 2012-08-27 11:09:50 | System Reset
    
    Change-Id: If6d0dced7cb0f5ca7038b3d758f31b856826d30b
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/southbridge/intel/bd82x6x/finalize.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/finalize.c b/src/southbridge/intel/bd82x6x/finalize.c
index fb6d5ec..7bd9f3f 100644
--- a/src/southbridge/intel/bd82x6x/finalize.c
+++ b/src/southbridge/intel/bd82x6x/finalize.c
@@ -32,11 +32,8 @@ void intel_pch_finalize_smm(void)
 	RCBA32(0x3898) = SPI_OPMENU_LOWER;
 	RCBA32(0x389c) = SPI_OPMENU_UPPER;
 
-/* Need to fix SMI driver use of opcode menu */
-#if !CONFIG_ELOG_GSMI
 	/* Lock SPIBAR */
 	RCBA32_OR(0x3804, (1 << 15));
-#endif
 
 	/* TCLOCKDN: TC Lockdown */
 	RCBA32_OR(0x0050, (1 << 31));




More information about the coreboot mailing list