[coreboot] Patch merged into coreboot/master: b6e1237 Move global variable check to Makefile

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 7 03:57:29 CET 2012

the following patch was just integrated into master:
commit b6e1237978f6aee4516263980f6bcf002d98ef20
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue Jul 31 14:52:04 2012 -0700

    Move global variable check to Makefile
    Our linker script for romstage checks for global variables and
    makes the build fail if there are any (on non-AMD systems).
    This is great, but having the build fail without any indication
    which variables are global is not very useful.
    Moving the check to the Makefile allows us to let the linking stage
    succeed and reveil which variable names end up in the data and bss
    sections of the binary.
    To test, add "int foo;" as the first line in src/mainboard/samsung/lumpy/romstage.c
    and build coreboot for Lumpy. See the build break the following
        LINK       cbfs/fallback/romstage_null.debug
        Forbidden global variables in romstage:
        00006a84 B foo
    Change-Id: I3c8780888f46a6577ffd36bcea317997b4f84f6f
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Reviewed-on: http://review.coreboot.org/1692
    Tested-by: build bot (Jenkins)
    Reviewed-by: Marc Jones <marcj303 at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Nov  7 01:45:20 2012, giving +1
See http://review.coreboot.org/1692 for details.


More information about the coreboot mailing list