[coreboot] Patch set updated for coreboot: fc56f2a ACPI: Zero pstate/cstate control values in FADT

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sun Nov 11 20:23:56 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1769

-gerrit

commit fc56f2a432a42f33b3b3d33782656cb764bbd02d
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Oct 3 19:23:11 2012 -0700

    ACPI: Zero pstate/cstate control values in FADT
    
    If these values are non-zero then the kernel will issue
    an SMI for each core (cstate) and package (pstate).
    
    Since we don't do anything with these SMI callbacks we
    can avoid taking the extra SMIs at boot time by zeroing
    these fields.
    
    Change-Id: I3bc5fe0a9f45141d46884cb77ecdfaeaa45d2439
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/intel/emeraldlake2/fadt.c | 4 ++--
 src/mainboard/samsung/lumpy/fadt.c      | 4 ++--
 src/mainboard/samsung/stumpy/fadt.c     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/intel/emeraldlake2/fadt.c b/src/mainboard/intel/emeraldlake2/fadt.c
index ff840c0..315cb58 100644
--- a/src/mainboard/intel/emeraldlake2/fadt.c
+++ b/src/mainboard/intel/emeraldlake2/fadt.c
@@ -47,7 +47,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
 	fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
 	fadt->s4bios_req = 0x0;
-	fadt->pstate_cnt = APM_CNT_PST_CONTROL;
+	fadt->pstate_cnt = 0;
 
 	fadt->pm1a_evt_blk = pmbase;
 	fadt->pm1b_evt_blk = 0x0;
@@ -65,7 +65,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->gpe0_blk_len = 16;
 	fadt->gpe1_blk_len = 0;
 	fadt->gpe1_base = 0;
-	fadt->cst_cnt = APM_CNT_CST_CONTROL;
+	fadt->cst_cnt = 0;
 	fadt->p_lvl2_lat = 1;
 	fadt->p_lvl3_lat = 87;
 	fadt->flush_size = 1024;
diff --git a/src/mainboard/samsung/lumpy/fadt.c b/src/mainboard/samsung/lumpy/fadt.c
index 6d78233..510b765 100644
--- a/src/mainboard/samsung/lumpy/fadt.c
+++ b/src/mainboard/samsung/lumpy/fadt.c
@@ -47,7 +47,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
 	fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
 	fadt->s4bios_req = 0x0;
-	fadt->pstate_cnt = APM_CNT_PST_CONTROL;
+	fadt->pstate_cnt = 0;
 
 	fadt->pm1a_evt_blk = pmbase;
 	fadt->pm1b_evt_blk = 0x0;
@@ -65,7 +65,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->gpe0_blk_len = 16;
 	fadt->gpe1_blk_len = 0;
 	fadt->gpe1_base = 0;
-	fadt->cst_cnt = APM_CNT_CST_CONTROL;
+	fadt->cst_cnt = 0;
 	fadt->p_lvl2_lat = 1;
 	fadt->p_lvl3_lat = 87;
 	fadt->flush_size = 1024;
diff --git a/src/mainboard/samsung/stumpy/fadt.c b/src/mainboard/samsung/stumpy/fadt.c
index ff840c0..315cb58 100644
--- a/src/mainboard/samsung/stumpy/fadt.c
+++ b/src/mainboard/samsung/stumpy/fadt.c
@@ -47,7 +47,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
 	fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
 	fadt->s4bios_req = 0x0;
-	fadt->pstate_cnt = APM_CNT_PST_CONTROL;
+	fadt->pstate_cnt = 0;
 
 	fadt->pm1a_evt_blk = pmbase;
 	fadt->pm1b_evt_blk = 0x0;
@@ -65,7 +65,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
 	fadt->gpe0_blk_len = 16;
 	fadt->gpe1_blk_len = 0;
 	fadt->gpe1_base = 0;
-	fadt->cst_cnt = APM_CNT_CST_CONTROL;
+	fadt->cst_cnt = 0;
 	fadt->p_lvl2_lat = 1;
 	fadt->p_lvl3_lat = 87;
 	fadt->flush_size = 1024;




More information about the coreboot mailing list