[coreboot] Patch merged into coreboot/master: ce407e4 libpayload: Implement correct interrupt-queue linking for UHCI

gerrit at coreboot.org gerrit at coreboot.org
Sat Nov 24 08:43:22 CET 2012

the following patch was just integrated into master:
commit ce407e470d36bd446e7e1f02884c97a98423d5c4
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Nov 20 17:27:46 2012 +0100

    libpayload: Implement correct interrupt-queue linking for UHCI
    The linking of interrupt queues into UHCI controller's framelist (in
    uhci_create_intr_queue()) was incomplete. The implementation of
    uhci_destroy_intr_queue() was even worse, looking like it wanted to
    clean up more than uhci_create_intr_queue() did.
    This patch follows the simple approach that we used for OHCI and EHCI:
    Each slot in the framelist holds only one interrupt queue. Therefore, we
    have to look for free slots each time we want to link an interrupt queue
    into the framelist. In return, we have a much simpler structured
    With this, USB devices using interrupt transfers (e.g. keyboards) can be
    detached cleanly from UHCI controllers. Also, more than one of such
    devices can be attached without further risk.
    Change-Id: I07b81a3b6f2cb3ff69515c973b3ae6321ad969aa
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: http://review.coreboot.org/1897
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Sat Nov 24 08:43:06 2012, giving +2
See http://review.coreboot.org/1897 for details.


More information about the coreboot mailing list