[coreboot] Patch merged into coreboot/master: 199b09c x86 realmode: Use x86emu register file + defines

gerrit at coreboot.org gerrit at coreboot.org
Sat Nov 24 20:11:46 CET 2012


the following patch was just integrated into master:
commit 199b09cb7a3c590ccbf8d705c98cfde101378f20
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Thu Nov 22 12:46:12 2012 +0100

    x86 realmode: Use x86emu register file + defines
    
    By using the (global) register file as defined by x86emu,
    we can use the same register access for YABEL and realmode
    interrupt handlers.
    
    - the x86 realmode interrupt handlers changed in signature
    - to access registers, use X86_$REGNAME now (eg. X86_EAX)
    - x86_exception_handler still uses struct eregs *regs to
      avoid spilling the x86emu register file stuff everywhere
    
    Coccinelle script that handled most of this commit:
      @ inthandler @
      identifier FUNC, regs;
      @@
      int FUNC(
      -struct eregs *regs
      +void
       )
      { ... }
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->eax
      +X86_EAX
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->ebx
      +X86_EBX
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->ecx
      +X86_ECX
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->edx
      +X86_EDX
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->esi
      +X86_ESI
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->edi
      +X86_EDI
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->eflags
      +X86_EFLAGS
    
      @ depends on inthandler @
      identifier regs;
      @@
      -regs->vector
      +M.x86.intno
    
    Change-Id: I60cc2c36646fe4b7f97457b1e297e3df086daa36
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
    Reviewed-on: http://review.coreboot.org/1891
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Fri Nov 23 14:32:41 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Sat Nov 24 20:11:45 2012, giving +2
See http://review.coreboot.org/1891 for details.

-gerrit




More information about the coreboot mailing list